Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java

Issue 10960002: "No SDK, No Problem!" (take 2) (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java (revision 12608)
+++ editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/info/DartModelInfo.java (working copy)
@@ -19,6 +19,7 @@
import com.google.dart.tools.core.internal.model.DartProjectNature;
import com.google.dart.tools.core.internal.model.PackageLibraryManagerProvider;
import com.google.dart.tools.core.model.DartLibrary;
+import com.google.dart.tools.core.model.DartSdkManager;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.resources.ResourcesPlugin;
@@ -28,7 +29,8 @@
import java.util.ArrayList;
/**
- * Instances of the class <code>DartModelInfo</code> maintain the cached data shared by all model objects.
+ * Instances of the class <code>DartModelInfo</code> maintain the cached data shared by all model
+ * objects.
*/
public class DartModelInfo extends OpenableElementInfo {
/**
@@ -91,12 +93,14 @@
private void initializeBundledLibraries() {
ArrayList<DartLibrary> libraries = new ArrayList<DartLibrary>();
+
try {
- PackageLibraryManager libraryManager = PackageLibraryManagerProvider
- .getPackageLibraryManager();
- coreLibrary = createBundledLibrary(libraryManager, "dart:core");
- for (String spec : libraryManager.getAllLibrarySpecs()) {
- libraries.add(createBundledLibrary(libraryManager, spec));
+ if (DartSdkManager.getManager().hasSdk()) {
+ PackageLibraryManager libraryManager = PackageLibraryManagerProvider.getPackageLibraryManager();
+ coreLibrary = createBundledLibrary(libraryManager, "dart:core");
+ for (String spec : libraryManager.getAllLibrarySpecs()) {
+ libraries.add(createBundledLibrary(libraryManager, spec));
+ }
}
} catch (URISyntaxException exception) {
throw new AssertionError(exception);

Powered by Google App Engine
This is Rietveld 408576698