Fallback to RGBA_8888 if readback format is not supported

Fallback to RGBA_8888 if readback format is not supported

In Async readback if the requested readback format is not supported.
Then fallback to RGBA_8888 format.

Removed RenderWidgetHostViewAndroid::PreferredReadbackFormat() API

Committed: https://crrev.com/ad8076150b45e2f02d730f4b958a3709df342fbc
Cr-Commit-Position: refs/heads/master@{#326741}

[patro, 2015-04-20 10:25:42]

behara.ms@samsung.com changed reviewers:
+ sievers@chromium.org

[patro, 2015-04-20 10:25:43]

Kindly Review

Thanks
Shyam Patro

[no sievers, 2015-04-22 20:20:39]

thanks, just two nits.

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:2006:
SkColorType preferred_color_type = color_type;
Can we make color_type non-const instead and overwrite it, so we don't
accidentally use the wrong variable somewhere in here?

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:2008: if
(gl_helper) {
nit: if (!gl_helper) return

[patro, 2015-04-23 09:43:46]

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:2006:
SkColorType preferred_color_type = color_type;
On 2015/04/22 20:20:39, sievers wrote:
> Can we make color_type non-const instead and overwrite it, so we don't
> accidentally use the wrong variable somewhere in here?

Done.

https://codereview.chromium.org/1095993002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:2008: if
(gl_helper) {
On 2015/04/22 20:20:39, sievers wrote:
> nit: if (!gl_helper) return

Done.

[no sievers, 2015-04-23 20:36:30]

lgtm

[no sievers, 2015-04-23 20:38:00]

+jaekyun,dtrainor FYI in case we use RGB565 readbacks.

[patro, 2015-04-24 03:54:19]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2015-04-24 03:54:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1095993002/40001

[commit-bot: I haz the power, 2015-04-24 04:37:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-24 04:37:57]

Patchset 3 (id:??) landed as
https://crrev.com/ad8076150b45e2f02d730f4b958a3709df342fbc
Cr-Commit-Position: refs/heads/master@{#326741}