Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Issue 1095953007: Default to arm_v7_neon. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Default to arm_v7_neon. This aliases all devices we know have NEON over to that too. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5ae0e2b56373b67a0fe6a0f9d7a0373712d1fa63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M platform_tools/android/bin/android_setup.sh View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtklein_C
5 years, 8 months ago (2015-04-21 17:04:29 UTC) #2
djsollen
lgtm
5 years, 8 months ago (2015-04-21 21:13:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095953007/1
5 years, 8 months ago (2015-04-21 21:17:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5ae0e2b56373b67a0fe6a0f9d7a0373712d1fa63
5 years, 8 months ago (2015-04-21 21:25:38 UTC) #6
Stephen White
This seems to have affected some GM results (unless gold is lying to me). E.g., ...
5 years, 8 months ago (2015-04-22 20:56:09 UTC) #7
mtklein
5 years, 8 months ago (2015-04-23 03:28:13 UTC) #8
Message was sent while issue was closed.
On 2015/04/22 20:56:09, Stephen White wrote:
> This seems to have affected some GM results (unless gold is lying to me).
> 
> E.g., https://gold.skia.org/#/triage/concavepaths?head=1
> 
> Was this expected?

Yes, though it's perhaps worth looking into.  sk_float_rsqrt() has a different
implementation when NEON is available, which is faster but somewhat lower
precision than the portable alternative.  This is used by
SkPoint::setLengthFast(), which is in turn used by distance field generation,
which I believe is used to draw these paths.  (Or at least that was the scenario
last time I traced it through.)  I've never seen it be a glaring problem, but if
we find places where the precision is noticeably too low, we can refine it with
another Newton's method step.

Powered by Google App Engine
This is Rietveld 408576698