Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: for landing Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png ('k') | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index 7cdc8e244986cf22db5c9d166fca5b22f28d6980..39b8b63b3e373efd6c3c34733858643bbd32ec2e 100644

--- a/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -217,6 +217,8 @@ WebInspector.PresentationConsoleMessageHelper.prototype = {

for (var i = 0; i < messages.length; i++) {

var message = messages[i];

var rawLocation = this._rawLocation(message);

+ if (!rawLocation)

+ continue;

if (script.target() === message.target() && script.scriptId === rawLocation.scriptId)

this._addConsoleMessageToScript(message, rawLocation);

else

« no previous file with comments | « Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png ('k') | Source/devtools/front_end/console/ConsoleView.js » ('j') | no next file with comments »