Source/devtools/front_end/sdk/NetworkManager.js - Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/NetworkManager.js

Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: comments addressed Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/sdk/ConsoleModel.js ('K') | « Source/devtools/front_end/sdk/ConsoleModel.js ('k') | Source/devtools/front_end/snippets/ScriptSnippetModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sdk/NetworkManager.js

diff --git a/Source/devtools/front_end/sdk/NetworkManager.js b/Source/devtools/front_end/sdk/NetworkManager.js

index a29d6cdfe4899f8c4df8bb7c82ea6ba11c60b4f9..0a9a57ce8d47fd90d6b6c7a8db89020ea2e18576 100644

--- a/Source/devtools/front_end/sdk/NetworkManager.js

+++ b/Source/devtools/front_end/sdk/NetworkManager.js

@@ -179,7 +179,7 @@ WebInspector.NetworkDispatcher.prototype = {

if (!this._mimeTypeIsConsistentWithType(networkRequest)) {

var consoleModel = this._manager._target.consoleModel;

- consoleModel.addMessage(new WebInspector.ConsoleMessage(consoleModel.target(), WebInspector.ConsoleMessage.MessageSource.Network,

+ consoleModel.addMessage(new WebInspector.ConsoleMessage(consoleModel.target(), 0, WebInspector.ConsoleMessage.MessageSource.Network,

WebInspector.ConsoleMessage.MessageLevel.Log,

WebInspector.UIString("Resource interpreted as %s but transferred with MIME type %s: \"%s\".", networkRequest.resourceType().title(), networkRequest.mimeType, networkRequest.url),

WebInspector.ConsoleMessage.MessageType.Log,