Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: comments addressed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorConsoleAgent.cpp
diff --git a/Source/core/inspector/InspectorConsoleAgent.cpp b/Source/core/inspector/InspectorConsoleAgent.cpp
index b8e9f09c994c129242686cd9972b14d9dec9c440..f294d03459af1b4c54e57fa92fe2acfcc454c580 100644
--- a/Source/core/inspector/InspectorConsoleAgent.cpp
+++ b/Source/core/inspector/InspectorConsoleAgent.cpp
@@ -162,6 +162,7 @@ static TypeBuilder::Console::ConsoleMessage::Level::Enum messageLevelValue(Messa
case WarningMessageLevel: return TypeBuilder::Console::ConsoleMessage::Level::Warning;
case ErrorMessageLevel: return TypeBuilder::Console::ConsoleMessage::Level::Error;
case InfoMessageLevel: return TypeBuilder::Console::ConsoleMessage::Level::Info;
+ case RevokedErrorMessageLevel: return TypeBuilder::Console::ConsoleMessage::Level::RevokedError;
}
return TypeBuilder::Console::ConsoleMessage::Level::Log;
}
@@ -172,6 +173,7 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
return;
RefPtr<TypeBuilder::Console::ConsoleMessage> jsonObj = TypeBuilder::Console::ConsoleMessage::create()
+ .setSequenceNumber(static_cast<int>(consoleMessage->sequenceNumber()))
.setSource(messageSourceValue(consoleMessage->source()))
.setLevel(messageLevelValue(consoleMessage->level()))
.setText(consoleMessage->message())
@@ -221,6 +223,8 @@ void InspectorConsoleAgent::sendConsoleMessageToFrontend(ConsoleMessage* console
if (asyncCallStack)
jsonObj->setAsyncStackTrace(asyncCallStack->buildInspectorObject());
}
+ if (consoleMessage->relatedSequenceNumber())
+ jsonObj->setRelatedSequenceNumber(consoleMessage->relatedSequenceNumber());
frontend()->messageAdded(jsonObj);
frontend()->flush();
}

Powered by Google App Engine
This is Rietveld 408576698