Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: LayoutTests/http/tests/inspector/console-test.js

Issue 1095943002: DevTools: [console] Logged promise rejections do not change state once handled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: comments addressed Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/inspector/console-test.js
diff --git a/LayoutTests/http/tests/inspector/console-test.js b/LayoutTests/http/tests/inspector/console-test.js
index fd216d5fca2db3f63600714b02e1df336519fcb1..2a39033b060818dc9285e1448aecc4cb3d187ee9 100644
--- a/LayoutTests/http/tests/inspector/console-test.js
+++ b/LayoutTests/http/tests/inspector/console-test.js
@@ -96,11 +96,11 @@ InspectorTest.dumpConsoleMessagesIntoArray = function(printOriginatingCommand, d
for (var i = 0; i < viewMessages.length; ++i) {
var uiMessage = viewMessages[i];
var message = uiMessage.consoleMessage();
- var element = uiMessage.contentElement();
+ var element = dumpClassNames ? uiMessage.toMessageElement() : uiMessage.contentElement();
if (dumpClassNames) {
var classNames = [];
- for (var node = element.firstChild; node; node = node.traverseNextNode(element)) {
+ for (var node = element; node; node = node.traverseNextNode(element)) {
if (node.nodeType === Node.ELEMENT_NODE && node.className)
classNames.push(node.className.replace("platform-linux", "platform-*").replace("platform-mac", "platform-*").replace("platform-windows", "platform-*"));
}
@@ -114,8 +114,8 @@ InspectorTest.dumpConsoleMessagesIntoArray = function(printOriginatingCommand, d
result.push(messageText + (dumpClassNames ? " " + classNames.join(" > ") : ""));
}
- if (printOriginatingCommand && uiMessage.consoleMessage().originatingMessage())
- result.push("Originating from: " + uiMessage.consoleMessage().originatingMessage().messageText);
+ if (printOriginatingCommand && uiMessage.consoleMessage().relatedMessage())
+ result.push("Originating from: " + uiMessage.consoleMessage().relatedMessage().messageText);
}
return result;
}

Powered by Google App Engine
This is Rietveld 408576698