DevTools: [console] Logged promise rejections do not change state once handled

Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 174 matching lines @@
                     default:
                         if (consoleMessage.parameters && consoleMessage.parameters.length === 1 && consoleMessage.parameters[0].type === "string")
                              this._messageElement = this._tryFormatAsError(/**@type {string} */(consoleMessage.parameters[0].value));
 
                         var args = consoleMessage.parameters || [consoleMessage.messageText];
                         this._messageElement = this._messageElement || this._format(args);
                 }
             } else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
                 if (consoleMessage.request) {
                     this._messageElement = createElement("span");
-                    if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error) {
+                    if (consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError) {
                         this._messageElement.createTextChildren(consoleMessage.request.requestMethod, " ");
                         this._messageElement.appendChild(WebInspector.Linkifier.linkifyUsingRevealer(consoleMessage.request, consoleMessage.request.url, consoleMessage.request.url));
                         if (consoleMessage.request.failed)
                             this._messageElement.createTextChildren(" ", consoleMessage.request.localizedFailDescription);
                         else
                             this._messageElement.createTextChildren(" ", String(consoleMessage.request.statusCode), " (", consoleMessage.request.statusText, ")");
                     } else {
                         var fragment = WebInspector.linkifyStringAsFragmentWithCustomLinkifier(consoleMessage.messageText, linkifyRequest.bind(consoleMessage));
                         this._messageElement.appendChild(fragment);
                     }
@@ skipping 24 matching lines @@
             }
         }
 
         this._formattedMessage.appendChild(this._messageElement);
         if (this._anchorElement) {
             // Append a space to prevent the anchor text from being glued to the console message when the user selects and copies the console messages.
             this._anchorElement.appendChild(createTextNode(" "));
             this._formattedMessage.insertBefore(this._anchorElement, this._formattedMessage.firstChild);
         }
 
-        var dumpStackTrace = !!consoleMessage.stackTrace && consoleMessage.stackTrace.length && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
+        var dumpStackTrace = !!consoleMessage.stackTrace && consoleMessage.stackTrace.length && (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.Error || consoleMessage.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError || consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace);
         if (dumpStackTrace) {
             var treeOutline = new TreeOutline();
             treeOutline.element.classList.add("outline-disclosure", "outline-disclosure-no-padding");
             var content = this._formattedMessage;
             var root = new TreeElement(content);
             root.toggleOnClick = true;
             root.selectable = false;
             content.treeElementForTest = root;
             treeOutline.appendChild(root);
             if (consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace)
@@ skipping 58 matching lines @@
     {
         var target = this._target();
         if (!target)
             return null;
         // FIXME(62725): stack trace line/column numbers are one-based.
         lineNumber = lineNumber ? lineNumber - 1 : 0;
         columnNumber = columnNumber ? columnNumber - 1 : 0;
         return this._linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber, columnNumber, "console-message-url");
     },
 
-    /**
-     * @return {boolean}
-     */
-    isErrorOrWarning: function()
-    {
-        return (this._message.level === WebInspector.ConsoleMessage.MessageLevel.Warning || this._message.level === WebInspector.ConsoleMessage.MessageLevel.Error);
-    },
-
     _format: function(parameters)
     {
         // This node is used like a Builder. Values are continually appended onto it.
         var formattedResult = createElement("span");
         if (!parameters.length)
             return formattedResult;
 
         var target = this._target();
 
         // Formatting code below assumes that parameters are all wrappers whereas frontend console
         // API allows passing arbitrary values as messages (strings, numbers, etc.). Wrap them here.
         for (var i = 0; i < parameters.length; ++i) {
             // FIXME: Only pass runtime wrappers here.
             if (parameters[i] instanceof WebInspector.RemoteObject)
                 continue;
 
             if (!target) {
                 parameters[i] = WebInspector.RemoteObject.fromLocalObject(parameters[i]);
                 continue;
             }
 
             if (typeof parameters[i] === "object")
                 parameters[i] = target.runtimeModel.createRemoteObject(parameters[i]);
             else
                 parameters[i] = target.runtimeModel.createRemoteObjectFromPrimitiveValue(parameters[i]);
         }
 
         // There can be string log and string eval result. We distinguish between them based on message type.
-        var shouldFormatMessage = WebInspector.RemoteObject.type(parameters[0]) === "string" && (this._message.type !== WebInspector.ConsoleMessage.MessageType.Result || this._message.level === WebInspector.ConsoleMessage.MessageLevel.Error);
+        var shouldFormatMessage = WebInspector.RemoteObject.type(parameters[0]) === "string" && (this._message.type !== WebInspector.ConsoleMessage.MessageType.Result || this._message.level === WebInspector.ConsoleMessage.MessageLevel.Error || this._message.level === WebInspector.ConsoleMessage.MessageLevel.RevokedError);
 
         // Multiple parameters with the first being a format string. Save unused substitutions.
         if (shouldFormatMessage) {
             // Multiple parameters with the first being a format string. Save unused substitutions.
             var result = this._formatWithSubstitutionString(parameters[0].description, parameters.slice(1), formattedResult);
             parameters = result.unusedSubstitutions;
             if (parameters.length)
                 formattedResult.createTextChild(" ");
         }
 
@@ skipping 568 matching lines @@
     },
 
     /**
      * @return {!Element}
      */
     toMessageElement: function()
     {
         if (this._wrapperElement)
             return this._wrapperElement;
 
-        this._wrapperElement = createElementWithClass("div", "console-message-wrapper");
+        this._wrapperElement = createElement("div");
+        this.updateMessageElement();
+        return this._wrapperElement;
+    },
+
+    updateMessageElement: function()
+    {
+        if (!this._wrapperElement)
+            return;
+
+        this._wrapperElement.className = "console-message-wrapper";
+        this._wrapperElement.removeChildren();
+
         this._nestingLevelMarkers = [];
         for (var i = 0; i < this._nestingLevel; ++i)
             this._nestingLevelMarkers.push(this._wrapperElement.createChild("div", "nesting-level-marker"));
         this._updateCloseGroupDecorations();
         this._wrapperElement.message = this;
 
         switch (this._message.level) {
         case WebInspector.ConsoleMessage.MessageLevel.Log:
             this._wrapperElement.classList.add("console-log-level");
             break;
         case WebInspector.ConsoleMessage.MessageLevel.Debug:
             this._wrapperElement.classList.add("console-debug-level");
             break;
         case WebInspector.ConsoleMessage.MessageLevel.Warning:
             this._wrapperElement.classList.add("console-warning-level");
             break;
         case WebInspector.ConsoleMessage.MessageLevel.Error:
             this._wrapperElement.classList.add("console-error-level");
             break;
+        case WebInspector.ConsoleMessage.MessageLevel.RevokedError:
+            this._wrapperElement.classList.add("console-revokedError-level");

[dgozman, 2015/04/21 09:16:36]

I didn't find where this is generated.

[pfeldman, 2015/04/21 12:15:27]

Ok, it is not! Still, it it a better name since it matches the form of
"console-" + level + "-level"

+            break;
         case WebInspector.ConsoleMessage.MessageLevel.Info:
             this._wrapperElement.classList.add("console-info-level");
             break;
         }
 
         this._wrapperElement.appendChild(this.contentElement());
-        return this._wrapperElement;
     },
 
     /**
      * @param {!TreeElement} parentTreeElement
      */
     _populateStackTraceTreeElement: function(parentTreeElement)
     {
         var target = this._target();
         if (!target)
             return;
@@ skipping 115 matching lines @@
                 break;
             case WebInspector.ConsoleMessage.MessageLevel.Warning:
                 levelString = "Warning";
                 break;
             case WebInspector.ConsoleMessage.MessageLevel.Debug:
                 levelString = "Debug";
                 break;
             case WebInspector.ConsoleMessage.MessageLevel.Error:
                 levelString = "Error";
                 break;
+            case WebInspector.ConsoleMessage.MessageLevel.RevokedError:
+                levelString = "RevokedError";
+                break;
             case WebInspector.ConsoleMessage.MessageLevel.Info:
                 levelString = "Info";
                 break;
         }
 
         return sourceString + " " + typeString + " " + levelString + ": " + this.formattedMessage().textContent + "\n" + this._message.url + " line " + this._message.line;
     },
 
     get text()
     {
@@ skipping 168 matching lines @@
     {
         if (!this._wrapperElement) {
             WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this);
             this._wrapperElement.classList.toggle("collapsed", this._collapsed);
         }
         return this._wrapperElement;
     },
 
     __proto__: WebInspector.ConsoleViewMessage.prototype
 }