extensions/browser/guest_view/guest_view_base.cc - Issue 1095913002: Fix window.open issue in Document mode on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 1095913002: Fix window.open issue in Document mode on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GuestViewBase delegate method Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index 48b9b2512aa7fbda76ecfa3a40e8e49af76f86c3..ad032142a42bdbbb16365e7279e5e74025575a28 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -656,6 +656,10 @@ void GuestViewBase::UpdateTargetURL(content::WebContents* source,

embedder_web_contents(), url);

}

+bool GuestViewBase::ShouldResumeRequestsForCreatedWindow() {

+ return false;

GuestViewBase::~GuestViewBase() {

}