content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 1095913002: Fix window.open issue in Document mode on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1095913002: Fix window.open issue in Document mode on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GuestViewBase delegate method Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 6e960cf30fc545d5718e1b065ccdbec234edece2..be0c55d4a09d0890ca779f9b926b760cd42c5eb6 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -193,6 +193,11 @@ import org.chromium.content_public.browser.WebContentsObserver;

}

@Override

+ public void resumeLoadingCreatedWebContents() {

+ nativeResumeLoadingCreatedWebContents(mNativeWebContentsAndroid);

+ }

+ @Override

public void setHasPendingNavigationTransitionForTesting() {

nativeSetHasPendingNavigationTransitionForTesting(mNativeWebContentsAndroid);

}

@@ -398,6 +403,7 @@ import org.chromium.content_public.browser.WebContentsObserver;

private native String nativeGetLastCommittedURL(long nativeWebContentsAndroid);

private native boolean nativeIsIncognito(long nativeWebContentsAndroid);

private native void nativeResumeResponseDeferredAtStart(long nativeWebContentsAndroid);

+ private native void nativeResumeLoadingCreatedWebContents(long nativeWebContentsAndroid);

private native void nativeSetHasPendingNavigationTransitionForTesting(

long nativeWebContentsAndroid);

private native void nativeSetupTransitionView(long nativeWebContentsAndroid,