Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1314)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 1095913002: Fix window.open issue in Document mode on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Typos Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 #if defined(OS_ANDROID) 129 #if defined(OS_ANDROID)
130 // In Android WebView, the RenderView needs created even there is no 130 // In Android WebView, the RenderView needs created even there is no
131 // navigation entry, this allows Android WebViews to use 131 // navigation entry, this allows Android WebViews to use
132 // javascript: URLs that load into the DOMWindow before the first page 132 // javascript: URLs that load into the DOMWindow before the first page
133 // load. This is not safe to do in any context that a web page could get a 133 // load. This is not safe to do in any context that a web page could get a
134 // reference to the DOMWindow before the first page load. 134 // reference to the DOMWindow before the first page load.
135 bool CreateRenderViewForInitialEmptyDocument(); 135 bool CreateRenderViewForInitialEmptyDocument();
136 #endif 136 #endif
137 137
138 // Unblocks requests from renderer for a newly created window. This is
139 // used in showCreatedWindow() or sometimes later in cases where
140 // delegate->ShouldResumeRequestsForCreatedWindow() indicated the requests
141 // should not yet be resumed. Then the client is responsible for calling this
142 // as soon as they are ready.
143 void ResumeLoadingCreatedWebContents();
144
138 // Expose the render manager for testing. 145 // Expose the render manager for testing.
139 // TODO(creis): Remove this now that we can get to it via FrameTreeNode. 146 // TODO(creis): Remove this now that we can get to it via FrameTreeNode.
140 RenderFrameHostManager* GetRenderManagerForTesting(); 147 RenderFrameHostManager* GetRenderManagerForTesting();
141 148
142 // Returns guest browser plugin object, or NULL if this WebContents is not a 149 // Returns guest browser plugin object, or NULL if this WebContents is not a
143 // guest. 150 // guest.
144 BrowserPluginGuest* GetBrowserPluginGuest() const; 151 BrowserPluginGuest* GetBrowserPluginGuest() const;
145 152
146 // Sets a BrowserPluginGuest object for this WebContents. If this WebContents 153 // Sets a BrowserPluginGuest object for this WebContents. If this WebContents
147 // has a BrowserPluginGuest then that implies that it is being hosted by 154 // has a BrowserPluginGuest then that implies that it is being hosted by
(...skipping 1136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 // Adds/removes a callback called on creation of each new WebContents. 1291 // Adds/removes a callback called on creation of each new WebContents.
1285 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1292 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1286 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1293 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1287 1294
1288 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1295 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1289 }; 1296 };
1290 1297
1291 } // namespace content 1298 } // namespace content
1292 1299
1293 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1300 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698