Fix window.open issue in Document mode on Android.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 1696 matching lines @@
 }
 
 void WebContentsImpl::ShowCreatedWindow(int route_id,
                                         WindowOpenDisposition disposition,
                                         const gfx::Rect& initial_rect,
                                         bool user_gesture) {
   WebContentsImpl* contents = GetCreatedWindow(route_id);
   if (contents) {
     WebContentsDelegate* delegate = GetDelegate();
     if (delegate) {
+      if (delegate->ShouldResumeRequestsForCreatedWindow())

[jam, 2015/04/20 16:05:41]

nit: instead of calling the line below twice, perhaps move this if statement out
of "if (delegate)" and make it "if (!delegate || delegate->Should...)"?

[Maria, 2015/04/20 23:40:07]

Done.

+        ResumeRequestsForCreatedWindow(*contents);
       delegate->AddNewContents(
           this, contents, disposition, initial_rect, user_gesture, NULL);
+    } else {
+      ResumeRequestsForCreatedWindow(*contents);
     }
   }
 }
 
 void WebContentsImpl::ShowCreatedWidget(int route_id,
                                         const gfx::Rect& initial_rect) {
   ShowCreatedWidget(route_id, false, initial_rect);
 }
 
 void WebContentsImpl::ShowCreatedFullscreenWidget(int route_id) {
@@ skipping 64 matching lines @@
   RemoveDestructionObserver(new_contents);
 
   // Don't initialize the guest WebContents immediately.
   if (BrowserPluginGuest::IsGuest(new_contents))
     return new_contents;
 
   if (!new_contents->GetRenderProcessHost()->HasConnection() ||
       !new_contents->GetRenderViewHost()->GetView())
     return NULL;
 
-  // Resume blocked requests for both the RenderViewHost and RenderFrameHost.
+  return new_contents;
+}
+
+void WebContentsImpl::ResumeRequestsForCreatedWindow(
+    WebContentsImpl& new_contents) {

[jam, 2015/04/20 16:05:41]

nit: not sure why this method is needed? i.e. why not just move the body to
ResumeLoadingCreatedWebContents? also the code above (line 1718) would be easier
to read if just contents->ResumeRequests...

[Maria, 2015/04/20 23:40:07]

The reason it's needed is that it gets called on all platforms. And the public
method I am exposing in webcontents in ifdef'd to Android.

Let me know if you prefer I get rid of this and make the other method open to
all platforms.

   // TODO(brettw): It seems bogus to reach into here and initialize the host.
-  static_cast<RenderViewHostImpl*>(new_contents->GetRenderViewHost())->Init();
-  static_cast<RenderFrameHostImpl*>(new_contents->GetMainFrame())->Init();
-
-  return new_contents;
+  static_cast<RenderViewHostImpl*>(new_contents.GetRenderViewHost())->Init();
+  static_cast<RenderFrameHostImpl*>(new_contents.GetMainFrame())->Init();
 }
 
 RenderWidgetHostView* WebContentsImpl::GetCreatedWidget(int route_id) {
   PendingWidgetViews::iterator iter = pending_widget_views_.find(route_id);
   if (iter == pending_widget_views_.end()) {
     DCHECK(false);
     return NULL;
   }
 
   RenderWidgetHostView* widget_host_view = iter->second;
@@ skipping 2717 matching lines @@
   FrameTreeNode* node = frame_tree_.root();
   node->render_manager()->ResumeResponseDeferredAtStart();
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
+#if defined(OS_ANDROID)
+void WebContentsImpl::ResumeLoadingCreatedWebContents() {
+  ResumeRequestsForCreatedWindow(*this);
+}
+#endif
+
+
 }  // namespace content