Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ipc/ipc_channel.cc

Issue 10959063: nacl: Fix a bunch of compiler warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ipc/ipc_channel.h" 5 #include "ipc/ipc_channel.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/atomic_sequence_num.h" 9 #include "base/atomic_sequence_num.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
11 #include "base/rand_util.h" 11 #include "base/rand_util.h"
12 #include "base/stringprintf.h" 12 #include "base/stringprintf.h"
13 13
14 #if !defined(OS_NACL)
14 namespace { 15 namespace {
15 16
16 // Global atomic used to guarantee channel IDs are unique. 17 // Global atomic used to guarantee channel IDs are unique.
17 base::StaticAtomicSequenceNumber g_last_id; 18 base::StaticAtomicSequenceNumber g_last_id;
18 19
19 } // namespace 20 } // namespace
21 #endif
20 22
21 namespace IPC { 23 namespace IPC {
22 24
23 // static 25 // static
24 std::string Channel::GenerateUniqueRandomChannelID() { 26 std::string Channel::GenerateUniqueRandomChannelID() {
25 // Note: the string must start with the current process id, this is how 27 // Note: the string must start with the current process id, this is how
26 // some child processes determine the pid of the parent. 28 // some child processes determine the pid of the parent.
27 // 29 //
28 // This is composed of a unique incremental identifier, the process ID of 30 // This is composed of a unique incremental identifier, the process ID of
29 // the creator, an identifier for the child instance, and a strong random 31 // the creator, an identifier for the child instance, and a strong random
30 // component. The strong random component prevents other processes from 32 // component. The strong random component prevents other processes from
31 // hijacking or squatting on predictable channel names. 33 // hijacking or squatting on predictable channel names.
32 34
33 #if !defined(OS_NACL) 35 #if !defined(OS_NACL)
34 int process_id = base::GetCurrentProcId(); 36 int process_id = base::GetCurrentProcId();
35 return base::StringPrintf("%d.%u.%d", 37 return base::StringPrintf("%d.%u.%d",
36 process_id, 38 process_id,
37 g_last_id.GetNext(), 39 g_last_id.GetNext(),
38 base::RandInt(0, std::numeric_limits<int32>::max())); 40 base::RandInt(0, std::numeric_limits<int32>::max()));
39 #else 41 #else
40 return std::string(); 42 return std::string();
41 #endif 43 #endif
42 } 44 }
43 45
44 } // namespace IPC 46 } // namespace IPC
45 47
OLDNEW
« no previous file with comments | « no previous file | ipc/ipc_channel_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698