nacl: Fix a bunch of compiler warnings

nacl: Fix a bunch of compiler warnings

BUG=148648
TBR=dmichael

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158232

[Nico, 2012-09-24 03:41:54]

Do you know why these warnings popped up all of a sudden? It looks like the code
hasn't changed in a while.

Brad: Any eta on -Werror in build_nexe?

[commit-bot: I haz the power, 2012-09-24 03:42:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10959063/1

[dmichael (off chromium), 2012-09-24 16:14:47]

lgtm, thanks!

[dmichael (off chromium), 2012-09-24 16:18:11]

On Sun, Sep 23, 2012 at 9:41 PM, <thakis@chromium.org> wrote:

> Reviewers: dmichael,
>
> Message:
> Do you know why these warnings popped up all of a sudden? It looks like
> the code
> hasn't changed in a while.
>
How recently did they pop up? It was in the last ~3 weeks I think that
these started getting built as dependencies of chrome.

I don't recall seeing them, though. It's very possible I was just blinded
by the build_nexe.py spew :(


> Brad: Any eta on -Werror in build_nexe?
>
> Description:
> nacl: Fix a bunch of compiler warnings
>
> BUG=148648
> TBR=dmichael
>
>
> Please review this at
https://codereview.chromium.**org/10959063/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M ipc/ipc_channel.cc
>   M ipc/ipc_channel_nacl.cc
>   M ppapi/proxy/plugin_main_nacl.**cc
>
>
> Index: ipc/ipc_channel.cc
> diff --git a/ipc/ipc_channel.cc b/ipc/ipc_channel.cc
> index 94e1cc4accc7dca764423dfd8dc5f8**72501e808e..**
> 37d693ad492869d24fa719bd5c13b1**cedf6ddc2a 100644
> --- a/ipc/ipc_channel.cc
> +++ b/ipc/ipc_channel.cc
> @@ -11,12 +11,14 @@
>  #include "base/rand_util.h"
>  #include "base/stringprintf.h"
>
> +#if !defined(OS_NACL)
>  namespace {
>
>  // Global atomic used to guarantee channel IDs are unique.
>  base::**StaticAtomicSequenceNumber g_last_id;
>
>  }  // namespace
> +#endif
>
>  namespace IPC {
>
> Index: ipc/ipc_channel_nacl.cc
> diff --git a/ipc/ipc_channel_nacl.cc b/ipc/ipc_channel_nacl.cc
> index 4231dd8bca8387ff73e048bee300c2**06cc318bf5..**
> e7f11db4ed60690006ca461733e2f8**edb52cd3ad 100644
> --- a/ipc/ipc_channel_nacl.cc
> +++ b/ipc/ipc_channel_nacl.cc
> @@ -261,7 +261,7 @@ bool Channel::ChannelImpl::**ProcessOutgoingMessages()
> {
>      output_queue_.pop_front();
>
>      int fds[FileDescriptorSet::**kMaxDescriptorsPerMessage];
> -    const int num_fds = msg->file_descriptor_set()->**size();
> +    const size_t num_fds = msg->file_descriptor_set()->**size();
>      DCHECK(num_fds <= FileDescriptorSet::**kMaxDescriptorsPerMessage);
>      msg->file_descriptor_set()->**GetDescriptors(fds);
>
> @@ -302,7 +302,7 @@ Channel::ChannelImpl::**ReadState
> Channel::ChannelImpl::**ReadData(
>      return READ_PENDING;
>    while (!read_queue_.empty() && *bytes_read < buffer_len) {
>      linked_ptr<std::vector<char> > vec(read_queue_.front());
> -    int bytes_to_read = buffer_len - *bytes_read;
> +    size_t bytes_to_read = buffer_len - *bytes_read;
>      if (vec->size() <= bytes_to_read) {
>        // We can read and discard the entire vector.
>        std::copy(vec->begin(), vec->end(), buffer + *bytes_read);
> Index: ppapi/proxy/plugin_main_nacl.**cc
> diff --git a/ppapi/proxy/plugin_main_**nacl.cc b/ppapi/proxy/plugin_main_*
> *nacl.cc
> index bd8dc7dd9590dafa2c92c44cb8dbc0**79f74c36e3..**
> aae60b063b0eabcb7242cd8c09938a**90579f2406 100644
> --- a/ppapi/proxy/plugin_main_**nacl.cc
> +++ b/ppapi/proxy/plugin_main_**nacl.cc
> @@ -136,7 +136,7 @@ void PpapiDispatcher::Unregister(**uint32
> plugin_dispatcher_id) {
>  }
>
>  bool PpapiDispatcher::**SendToBrowser(IPC::Message* msg) {
> -  Send(msg);
> +  return Send(msg);
>  }
>
>  IPC::Sender* PpapiDispatcher::**GetBrowserSender() {
>
>
>