Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10959048: Do not collect smi values with no ssa index for range analysis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index c056e16c062c1edaa779d2e8e015af5832970177..19326527499c6b7b14c5b908fade1a467b3aba19 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -1303,7 +1303,10 @@ void RangeAnalysis::CollectSmiValues() {
Instruction* current = instr_it.Current();
Definition* defn = current->AsDefinition();
if (defn != NULL) {
- if (defn->GetPropagatedCid() == kSmiCid) smi_values_.Add(defn);
+ if ((defn->GetPropagatedCid() == kSmiCid) &&
+ (defn->ssa_temp_index() != -1)) {
Florian Schneider 2012/09/24 08:54:30 ssa_temp_index != -1 should be equivalent to defn-
+ smi_values_.Add(defn);
+ }
} else if (current->IsCheckSmi()) {
smi_checks_.Add(current->AsCheckSmi());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698