Issue 10959039: Move Android's build_output_dirs target to its own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10959039: Move Android's build_output_dirs target to its own file. (Closed)

Created:
8 years, 3 months ago by Peter Beverloo

Modified:
8 years, 3 months ago

Reviewers:
shashi, bulach

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move Android's build_output_dirs target to its own file. We shouldn't have logic in all_android.gyp. The purpose of that file is solely to have a list of dependencies which should be build when creating a gyp file for Android. BUG= TEST=gyp generation works. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157963

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -31 lines)			Patch
M	build/all_android.gyp	View	1 chunk	+0 lines, -30 lines	0 comments	Download
A	build/build_output_dirs_android.gyp	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	build/java.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm, thanks!

Expand Messages | Collapse Messages