Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7148)

Unified Diff: content/browser/renderer_host/render_widget_host_view_win.cc

Issue 10959024: Ensure that the OSK does not show up at times when you click on editable fields with the mouse. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_win.cc
===================================================================
--- content/browser/renderer_host/render_widget_host_view_win.cc (revision 157261)
+++ content/browser/renderer_host/render_widget_host_view_win.cc (working copy)
@@ -1845,7 +1845,8 @@
}
}
- if (message == WM_LBUTTONDOWN && GetBrowserAccessibilityManager())
+ if (message == WM_LBUTTONDOWN && pointer_down_context_ &&
+ GetBrowserAccessibilityManager())
GetBrowserAccessibilityManager()->GotMouseDown();
if (message == WM_LBUTTONUP && ui::IsMouseEventFromTouch(message) &&
@@ -2211,6 +2212,11 @@
return 0;
}
+ if (total == 1) {
sky 2012/09/20 20:08:14 combine into a single if.
ananta 2012/09/20 22:00:11 Done.
+ if (points[0].dwFlags & TOUCHEVENTF_DOWN)
+ pointer_down_context_ = true;
+ }
+
bool has_touch_handler = render_widget_host_->has_touch_handler() &&
touch_events_enabled_;
@@ -2690,8 +2696,8 @@
lparam = MAKELPARAM(point.x, point.y);
if (message == WM_POINTERDOWN) {
- pointer_down_context_ = true;
if (!base::win::IsMetroProcess()) {
+ pointer_down_context_ = true;
sky 2012/09/20 20:08:14 One other question, should we force to false in ca
ananta 2012/09/20 22:00:11 Good point. Done.
SetFocus();
received_focus_change_after_pointer_down_ = false;
MessageLoop::current()->PostDelayedTask(FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698