Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10959024: Ensure that the OSK does not show up at times when you click on editable fields with the mouse. (Closed)

Created:
8 years, 3 months ago by ananta
Modified:
8 years, 3 months ago
Reviewers:
dmazzoni, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Ensure that the OSK does not show up at times when you click on editable fields with the mouse. In metro mode the WM_POINTER message is sent on mouse clicks as well as opposed to desktop mode where it only shows up when you touch the window. Fix is to set the pointer_down_context_ variable to true in the OnTouchHandler when we receive a single touch. BUG=150848 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157864

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/browser/accessibility/browser_accessibility_manager.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ananta
8 years, 3 months ago (2012-09-20 19:47:21 UTC) #1
sky
https://codereview.chromium.org/10959024/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): https://codereview.chromium.org/10959024/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc#newcode2215 content/browser/renderer_host/render_widget_host_view_win.cc:2215: if (total == 1) { combine into a single ...
8 years, 3 months ago (2012-09-20 20:08:14 UTC) #2
ananta
https://codereview.chromium.org/10959024/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc File content/browser/renderer_host/render_widget_host_view_win.cc (right): https://codereview.chromium.org/10959024/diff/1/content/browser/renderer_host/render_widget_host_view_win.cc#newcode2215 content/browser/renderer_host/render_widget_host_view_win.cc:2215: if (total == 1) { On 2012/09/20 20:08:14, sky ...
8 years, 3 months ago (2012-09-20 22:00:11 UTC) #3
dmazzoni
lgtm for accessibility
8 years, 3 months ago (2012-09-20 22:47:35 UTC) #4
sky
8 years, 3 months ago (2012-09-20 22:53:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698