Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_parseNum_CleanUp.java

Issue 10959006: Clean up to migrate parseInt() and parseDouble() to int.parse() and double.parse() (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_parseNum_CleanUp.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_parseNum_CleanUp.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_parseNum_CleanUp.java
new file mode 100644
index 0000000000000000000000000000000000000000..297cc39d7cd0d2c08e040a2ad02598051df6c522
--- /dev/null
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_parseNum_CleanUp.java
@@ -0,0 +1,73 @@
+/*
+ * Copyright (c) 2012, the Dart project authors.
+ *
+ * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.dart.tools.ui.internal.cleanup.migration;
+
+import com.google.dart.compiler.Source;
+import com.google.dart.compiler.ast.ASTVisitor;
+import com.google.dart.compiler.ast.DartExpression;
+import com.google.dart.compiler.ast.DartInvocation;
+import com.google.dart.compiler.ast.DartMethodInvocation;
+import com.google.dart.compiler.ast.DartUnqualifiedInvocation;
+import com.google.dart.compiler.resolver.Element;
+import com.google.dart.compiler.resolver.Elements;
+import com.google.dart.compiler.resolver.MethodElement;
+import com.google.dart.tools.core.model.SourceRange;
+import com.google.dart.tools.core.utilities.general.SourceRangeFactory;
+
+/**
+ * In specification 1.0 M1 <code>parseInt()</code> and <code>parseDouble()</code> replaced with
+ * <code>int.parse()</code> and <code>double.parse()</code>.
+ *
+ * @coverage dart.editor.ui.cleanup
+ */
+public class Migrate_1M1_parseNum_CleanUp extends AbstractMigrateCleanUp {
+ @Override
+ protected void createFix() {
+ unitNode.accept(new ASTVisitor<Void>() {
+ @Override
+ public Void visitMethodInvocation(DartMethodInvocation node) {
+ processInvocation(node);
+ return super.visitMethodInvocation(node);
+ }
+
+ @Override
+ public Void visitUnqualifiedInvocation(DartUnqualifiedInvocation node) {
+ processInvocation(node);
+ return super.visitUnqualifiedInvocation(node);
+ }
+
+ private void processInvocation(DartInvocation node) {
+ Element element = node.getElement();
+ if (element instanceof MethodElement && node.getArguments().size() == 1) {
+ MethodElement methodElement = (MethodElement) element;
+ boolean parseInt = methodElement.getName().equals("parseInt");
+ boolean parseDouble = methodElement.getName().equals("parseDouble");
+ if (parseInt || parseDouble) {
+ Source source = element.getSourceInfo().getSource();
+ if (Elements.isLibrarySource(source, "/math/math.dart")) {
+ DartExpression argument = node.getArguments().get(0);
+ SourceRange range = SourceRangeFactory.forStartStart(node, argument);
+ if (parseInt) {
+ addReplaceEdit(range, "int.parse(");
+ }
+ if (parseDouble) {
+ addReplaceEdit(range, "double.parse(");
+ }
+ }
+ }
+ }
+ }
+ });
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698