Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1095893004: [mjsunit] Fix bad test expectations. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
Reviewers:
ulan, vogelheim, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mjsunit] Fix bad test expectations. BUG=v8:3924, v8:3969, chromium:478788 NOTRY=true LOG=n Committed: https://crrev.com/8244686f6deaa627fed6ec68984b235e55d2dd3e Cr-Commit-Position: refs/heads/master@{#28019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Achenbach
PTAL. All these expectations could have never worked. The first two refer to fixed issues, ...
5 years, 8 months ago (2015-04-22 15:01:40 UTC) #3
vogelheim
lgtm Thanks for double checking.
5 years, 8 months ago (2015-04-22 15:26:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095893004/1
5 years, 8 months ago (2015-04-22 21:21:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 21:22:42 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 21:22:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8244686f6deaa627fed6ec68984b235e55d2dd3e
Cr-Commit-Position: refs/heads/master@{#28019}

Powered by Google App Engine
This is Rietveld 408576698