gpu/command_buffer/tests/gl_manager.cc - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_manager.cc

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix GLManager and fix another resource leak (comment #15) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_lost.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc ('k') | gpu/gpu.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_manager.cc

diff --git a/gpu/command_buffer/tests/gl_manager.cc b/gpu/command_buffer/tests/gl_manager.cc

index 8988349eaa4be81a22f38e1b44edd5c6d2e46d01..15ace43c6ffdadb66507821730329c222df206f1 100644

--- a/gpu/command_buffer/tests/gl_manager.cc

+++ b/gpu/command_buffer/tests/gl_manager.cc

@@ -404,8 +404,8 @@ void GLManager::Destroy() {

gles2_helper_.reset();

command_buffer_.reset();

if (decoder_.get()) {

- decoder_->MakeCurrent();

- decoder_->Destroy(true);

+ bool have_context = decoder_->MakeCurrent();

+ decoder_->Destroy(have_context);

decoder_.reset();

}