content/renderer/render_thread_impl.cc - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix GLManager and fix another resource leak (comment #15) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/gpu_command_buffer_stub.cc ('K') | « content/renderer/pepper/ppb_graphics_3d_impl.cc ('k') | content/renderer/render_widget.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_thread_impl.cc

diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc

index 61fd8409dfa26dbbb2a2e52266667ea9a2d9180f..acda8a70f33dea4c697f4dadd93a8e3e830c7042 100644

--- a/content/renderer/render_thread_impl.cc

+++ b/content/renderer/render_thread_impl.cc

@@ -1294,7 +1294,7 @@ RenderThreadImpl::GetGpuFactories() {

GURL("chrome://gpu/RenderThreadImpl::GetGpuVDAContext3D"),

WebGraphicsContext3DCommandBufferImpl::SharedMemoryLimits(),

NULL)),

- "GPU-VideoAccelerator-Offscreen");

+ GPU_VIDEO_ACCELERATOR_CONTEXT);

}

if (gpu_va_context_provider_.get()) {

@@ -1336,7 +1336,7 @@ RenderThreadImpl::SharedMainThreadContextProvider() {

#endif

if (!shared_main_thread_contexts_.get()) {

shared_main_thread_contexts_ = ContextProviderCommandBuffer::Create(

- CreateOffscreenContext3d(), "Offscreen-MainThread");

+ CreateOffscreenContext3d(), RENDERER_MAINTHREAD_CONTEXT);

}

if (shared_main_thread_contexts_.get() &&

!shared_main_thread_contexts_->BindToCurrentThread())