content/renderer/pepper/pepper_video_encoder_host.cc - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_video_encoder_host.cc

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix GLManager and fix another resource leak (comment #15) Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/gpu_command_buffer_stub.cc ('K') | « content/content_common.gypi ('k') | content/renderer/pepper/ppb_graphics_3d_impl.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_video_encoder_host.cc

diff --git a/content/renderer/pepper/pepper_video_encoder_host.cc b/content/renderer/pepper/pepper_video_encoder_host.cc

index 39292bbcb677031ba002023cf063a0333475a699..7c0b9fd0bf585fbb74b3dcc349f586a225a74176 100644

--- a/content/renderer/pepper/pepper_video_encoder_host.cc

+++ b/content/renderer/pepper/pepper_video_encoder_host.cc

@@ -513,7 +513,7 @@ bool PepperVideoEncoderHost::EnsureGpuChannel() {

return false;

}

- command_buffer_->SetChannelErrorCallback(media::BindToCurrentLoop(

+ command_buffer_->SetContextLostCallback(media::BindToCurrentLoop(

base::Bind(&PepperVideoEncoderHost::NotifyPepperError,

weak_ptr_factory_.GetWeakPtr(), PP_ERROR_RESOURCE_FAILED)));

if (!command_buffer_->Initialize()) {