Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5432)

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: disable blocking test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
index fff003698e3e3ba65378d417d23a3314b15354de..bf10e17fba08c56b2f681289b1ce4fd6c79c5de7 100644
--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
@@ -19,7 +19,10 @@ namespace policy {
class UserCloudPolicyManagerTest : public LoginPolicyTestBase {
protected:
- UserCloudPolicyManagerTest() : LoginPolicyTestBase() {}
+ UserCloudPolicyManagerTest() : LoginPolicyTestBase() {
+ // TODO(nkostylev): Fix this test for webview. http://crbug.com/477402
+ set_use_webview(false);
Dmitry Polukhin 2015/04/22 06:47:07 ditto
Nikita (slow) 2015/04/22 09:01:45 Done.
+ }
scoped_ptr<base::DictionaryValue> GetMandatoryPoliciesValue() const override {
scoped_ptr<base::ListValue> list(new base::ListValue);
@@ -38,7 +41,7 @@ class UserCloudPolicyManagerTest : public LoginPolicyTestBase {
DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyManagerTest);
};
-IN_PROC_BROWSER_TEST_F(UserCloudPolicyManagerTest, StartSession) {
+IN_PROC_BROWSER_TEST_P(UserCloudPolicyManagerTest, StartSession) {
const char* const kStartupURLs[] = {"chrome://policy", "chrome://about"};
SkipToLoginScreen();
@@ -61,4 +64,8 @@ IN_PROC_BROWSER_TEST_F(UserCloudPolicyManagerTest, StartSession) {
}
}
+INSTANTIATE_TEST_CASE_P(UserCloudPolicyManagerTestSuite,
+ UserCloudPolicyManagerTest,
+ testing::Bool());
+
} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698