chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc - Issue 1095843003: [cros] Modify oobe/login tests to work with webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disable blocking test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc ('K') | « chrome/browser/chromeos/login/login_manager_test.cc ('k') | chrome/browser/chromeos/login/startup_utils.cc » ('j') | chrome/browser/chromeos/login/startup_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

diff --git a/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc b/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

index 3eef72f7496d7905ec0afda37cd508c0d36adbb2..f8fd023295363f753799954f109190762a8a93ad 100644

--- a/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

+++ b/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

@@ -69,8 +69,8 @@ class ProxyAuthOnUserBoardScreenTest

net::SpawnedTestServer::kLocalhost,

base::FilePath()) {

// TODO(paulmeyer): Re-enable webview version of this test

- // (uncomment this line) once http://crbug.com/452452 is fixed.

- // set_use_webview(GetParam());

+ // (once http://crbug.com/452452 is fixed.

+ set_use_webview(false);

Dmitry Polukhin 2015/04/22 06:47:07 dito, there is no sense t run the same test twice

Nikita (slow) 2015/04/22 09:01:45 Done.

}

~ProxyAuthOnUserBoardScreenTest() override {}