Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Side by Side Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 10958078: Merge 157974 - A crash fix: removed the entire implicated section as obsolete. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1271/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h" 5 #include "chrome/browser/ui/startup/startup_browser_creator_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 779 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 if (!browser->tab_count()) 790 if (!browser->tab_count())
791 chrome::AddBlankTab(browser, true); 791 chrome::AddBlankTab(browser, true);
792 else 792 else
793 chrome::ActivateTabAt(browser, 0, false); 793 chrome::ActivateTabAt(browser, 0, false);
794 } 794 }
795 795
796 // The default behaviour is to show the window, as expressed by the default 796 // The default behaviour is to show the window, as expressed by the default
797 // value of StartupBrowserCreated::show_main_browser_window_. If this was set 797 // value of StartupBrowserCreated::show_main_browser_window_. If this was set
798 // to true ahead of this place, it means another task must have been spawned 798 // to true ahead of this place, it means another task must have been spawned
799 // to take care of that. 799 // to take care of that.
800 if (!browser_creator_ || browser_creator_->show_main_browser_window()) { 800 if (!browser_creator_ || browser_creator_->show_main_browser_window())
801 browser->window()->Show(); 801 browser->window()->Show();
802 // TODO(jcampan): http://crbug.com/8123 we should not need to set the
803 // initial focus explicitly.
804 chrome::GetActiveWebContents(browser)->GetView()->SetInitialFocus();
805 }
806 802
807 return browser; 803 return browser;
808 } 804 }
809 805
810 void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary( 806 void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary(
811 Browser* browser, 807 Browser* browser,
812 chrome::startup::IsProcessStartup is_process_startup) { 808 chrome::startup::IsProcessStartup is_process_startup) {
813 if (!browser || !profile_ || browser->tab_count() == 0) 809 if (!browser || !profile_ || browser->tab_count() == 0)
814 return; 810 return;
815 811
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
942 // New: 938 // New:
943 prefs->GetString(prefs::kHomePage), 939 prefs->GetString(prefs::kHomePage),
944 prefs->GetBoolean(prefs::kHomePageIsNewTabPage), 940 prefs->GetBoolean(prefs::kHomePageIsNewTabPage),
945 prefs->GetBoolean(prefs::kShowHomeButton), 941 prefs->GetBoolean(prefs::kShowHomeButton),
946 // Backup: 942 // Backup:
947 backup_homepage, 943 backup_homepage,
948 backup_homepage_is_ntp, 944 backup_homepage_is_ntp,
949 backup_show_home_button)); 945 backup_show_home_button));
950 } 946 }
951 } 947 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698