Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10958068: Merge 129191 - [Platform] There are memory leak in LocaleICU (Closed)

Created:
8 years, 3 months ago by karen
Modified:
8 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 129191 - [Platform] There are memory leak in LocaleICU https://bugs.webkit.org/show_bug.cgi?id=97289 Reviewed by Kent Tamura. This patch adds udt_close() calls for medium time format and short time format data used in LocaleICU class to avoid memory leak. This memory leak is found by external tool Valgrind and reported in Chromium bug repositry(http://crbug.com/151006) with stack trace of call path of leaked memory. This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. No new tests. External tool such as Valgrind will check this memory leak. * platform/text/LocaleICU.cpp: (WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat and m_shortTimeFormat which have UDateFormat objects. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129363

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/WebCore/platform/text/LocaleICU.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 3 months ago (2012-09-24 14:22:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698