Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10958066: Get rid of the content::NOTIFICATION_APP_ACTIVATED notification since it was fired from Chrome (con… (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 3 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Get rid of the content::NOTIFICATION_APP_ACTIVATED notification since it was fired from Chrome (content notifications should only be fired from content). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -44 lines) Patch
M chrome/browser/app_controller_mac.mm View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/plugin_service_impl.h View 5 chunks +4 lines, -11 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 4 chunks +7 lines, -23 lines 0 comments Download
M content/public/browser/notification_types.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/browser/plugin_service.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 3 months ago (2012-09-24 14:46:04 UTC) #1
Avi (use Gerrit)
8 years, 3 months ago (2012-09-24 14:50:03 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698