media/audio/audio_output_dispatcher_impl.h - Issue 10958020: Don't fallback if we've successfully opened a stream previously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_output_dispatcher_impl.h

Issue 10958020: Don't fallback if we've successfully opened a stream previously. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments w/o state machine. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/audio_output_dispatcher_impl.h

diff --git a/media/audio/audio_output_dispatcher_impl.h b/media/audio/audio_output_dispatcher_impl.h

index 8ad7dda565888a9740ac8107740638c449c8ff2e..0eaa651f2ed1f50145bd935534a2d1060071b52c 100644

--- a/media/audio/audio_output_dispatcher_impl.h

+++ b/media/audio/audio_output_dispatcher_impl.h

@@ -40,7 +40,7 @@ class MEDIA_EXPORT AudioOutputDispatcherImpl : public AudioOutputDispatcher {

const base::TimeDelta& close_delay);

// Opens a new physical stream if there are no pending streams in

- // |idle_streams_|.

+ // |idle_streams_|. Do not call Close() or Stop() if this method fails.

virtual bool OpenStream() OVERRIDE;

// If there are pending streams in |idle_streams_| then it reuses one of