Revert 157667 - Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

Revert 157667 - Add new PathService paths for Windows' All Users Desktop and Quick Launch folders.

The previous patch failed PathServiceTest.Get.

This allows usage of PathService to cache the paths and more importantly to mock them in shortcut tests!

Also move chrome::DIR_USER_DESKTOP to base::DIR_USER_DESKTOP; this is really where it belongs. In fact it is only in chrome_paths.h because it used to be called DIR_DEFAULT_DOWNLOAD and cpu@ renamed it to DIR_USER_DESKTOP in http://crrev.com/1753 (early days!) after that it started to be used all over the place as the Desktop path. Finally bringing it to base_paths.h, beside DIR_START_MENU and friends, is the right thing to do imo.

BUG=148539
TEST=Quick Launch shortcut installed in the right place on XP (both Default and current user)
Desktop shortcuts installed in the right place (both All Users and per-user installs).

installer_util_unittests.exe --gtest_filter=ShellUtilShortcutTest*
unit_tests.exe --gtest_filter=ProfileShortcutManagerTest*
base_unittests --gtest_filter=PathServiceTest*

Review URL: https://chromiumcodereview.appspot.com/10910209

TBR=gab@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157680

[wjia1, 2012-09-20 02:03:25]

FYI, PathServiceTest.Get failed in a row:

http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28...

http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28...

[gab, 2012-09-20 02:20:25]

lgtm, thanks.

[Finnur, 2013-04-15 14:01:21]

Hmmm... here's something a bit odd.

I'm investigating this bug:
https://code.google.com/p/chromium/issues/detail?id=230766

I bisected the builds and found that the last build that worked was r157677 and
the first one that failed was r157692.

What's that got to do with this CL, you ask?

Well, the former revision is the exact revision when gab checked in the
PathService change and the latter is the first build after jiwa reverted it.

Somehow, gab's checkin is making the Extension Popups work.

I've browsed through gab's CL but I don't quite understand how they are related.

Any ideas?

[Finnur, 2013-04-15 14:22:48]

Hmmm... it looks like this was checked in again later. But this time the bug
remains. :/

[Finnur, 2013-04-15 15:39:36]

Looks like this was a false alarm. Threaded compositing is the suspected culprit
in this case. Move along, nothing to see. :)