Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1095793007: Disable two test cases for turbofan unsupported platform. (Closed)

Created:
5 years, 8 months ago by chunyang.dai
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable two test cases for turbofan unsupported platform. These two test cases "InlineCreateArrayLiteral" and "InlineCreateObjectLiteral" are added in d1597b7d22d4bd7790715d486b4ceb404310adad. They invokes Linkage::GetStubCallDescriptor which is unimplemented for turbofan unsupported platform. BUG= Committed: https://crrev.com/e31f5ec7ebeec887b4c46119a7e7291fce86df6c Cr-Commit-Position: refs/heads/master@{#28090}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-22 08:38:14 UTC) #2
Michael Starzinger
LGTM. Will need to be rebased on top of: https://codereview.chromium.org/1104453006/
5 years, 8 months ago (2015-04-27 09:15:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095793007/20001
5 years, 8 months ago (2015-04-27 16:25:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 17:02:54 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 17:03:09 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e31f5ec7ebeec887b4c46119a7e7291fce86df6c
Cr-Commit-Position: refs/heads/master@{#28090}

Powered by Google App Engine
This is Rietveld 408576698