Implement onOpenResult.

chrome/browser/chromeos/launcher_search_provider/service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/launcher_search_provider/service.h"
 
 #include "base/memory/scoped_vector.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/launcher_search_provider/service_factory.h"
 #include "chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h"
@@ skipping 66 matching lines @@
         extension_id,
         make_scoped_ptr(new extensions::Event(
             api_launcher_search_provider::OnQueryEnded::kEventName,
             api_launcher_search_provider::OnQueryEnded::Create(
                 std::to_string(query_id_)))));
   }
 
   is_query_running_ = false;
 }
 
+void Service::OnOpenResult(const ExtensionId& extension_id,
+                           const std::string& item_id) {
+  DCHECK(ContainsValue(GetListenerExtensionIds(), extension_id));
+
+  extensions::EventRouter* event_router =
+      extensions::EventRouter::Get(profile_);
+  event_router->DispatchEventToExtension(
+      extension_id,
+      make_scoped_ptr(new extensions::Event(
+          api_launcher_search_provider::OnOpenResult::kEventName,
+          api_launcher_search_provider::OnOpenResult::Create(item_id))));
+}
+
 void Service::SetSearchResults(
     const extensions::Extension* extension,
     const std::string& query_id,
     const std::vector<linked_ptr<
         extensions::api::launcher_search_provider::SearchResult>>& results) {
   // If query is not running or query_id is different from current query id,
   // discard the results.
   if (!is_query_running_ || query_id != std::to_string(query_id_))
     return;
 
+  // If |extension| is not in the listener extensions list, ignore it.
+  if (!ContainsValue(GetListenerExtensionIds(), extension->id()))

[yawano, 2015/04/20 04:02:36]

I noticed that we haven't checked extension id here. If they can get (or
estimate) query_id, not-allowed extensions could have set search results.

+    return;
+
   // Set search results to provider.
   DCHECK(provider_);
   ScopedVector<app_list::LauncherSearchResult> search_results;
   for (const auto& result : results) {
     const int relevance =
         std::min(kMaxSearchResultScore, std::max(result->relevance, 0));
     const GURL icon_url =
         result->icon_url ? GURL(*result->icon_url.get()) : GURL();
 
     app_list::LauncherSearchResult* search_result =
@@ skipping 20 matching lines @@
         extensions::APIPermission::kLauncherSearchProvider);
     if (has_permission)
       extension_ids.insert(extension->id());
   }
 
   return extension_ids;
 }
 
 }  // namespace launcher_search_provider
 }  // namespace chromeos