Implement onOpenResult.

chrome/browser/chromeos/launcher_search_provider/service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/launcher_search_provider/service.h"
 
 #include "base/memory/scoped_vector.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/launcher_search_provider/service_factory.h"
 #include "chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h"
@@ skipping 66 matching lines @@
         extension_id,
         make_scoped_ptr(new extensions::Event(
             api_launcher_search_provider::OnQueryEnded::kEventName,
             api_launcher_search_provider::OnQueryEnded::Create(
                 std::to_string(query_id_)))));
   }
 
   is_query_running_ = false;
 }
 
+void Service::OnOpenResult(const ExtensionId& extension_id,
+                           const std::string& item_id) {
+  // If |extension| is not contained in listener extension, ignore it.
+  std::set<ExtensionId> extension_ids = GetListenerExtensionIds();
+  if (!ContainsValue(extension_ids, extension_id))

[Matt Giuca, 2015/04/20 02:44:52]

Is there any reason to expect this to happen during normal operation? I can't
see how it would ever occur that a search result would have an extension ID of a
non-listener extension. Therefore, we could potentially CHECK here instead of
returning silently.

[yawano, 2015/04/20 04:02:36]

Yes, this could not happen since extension_id is set at when the result is
generated (the value should be validated at the creation time). Changed this to
DCHECK.

[Matt Giuca, 2015/04/20 04:36:26]

I think it should be a CHECK because it would be a security issue if it were not
satisfied.

[yawano, 2015/04/20 04:46:22]

Done.

+    return;
+
+  extensions::EventRouter* event_router =
+      extensions::EventRouter::Get(profile_);
+  event_router->DispatchEventToExtension(
+      extension_id,
+      make_scoped_ptr(new extensions::Event(
+          api_launcher_search_provider::OnOpenResult::kEventName,
+          api_launcher_search_provider::OnOpenResult::Create(item_id))));
+}
+
 void Service::SetSearchResults(
     const extensions::Extension* extension,
     const std::string& query_id,
     const std::vector<linked_ptr<
         extensions::api::launcher_search_provider::SearchResult>>& results) {
   // If query is not running or query_id is different from current query id,
   // discard the results.
   if (!is_query_running_ || query_id != std::to_string(query_id_))
     return;
 
@@ skipping 30 matching lines @@
         extensions::APIPermission::kLauncherSearchProvider);
     if (has_permission)
       extension_ids.insert(extension->id());
   }
 
   return extension_ids;
 }
 
 }  // namespace launcher_search_provider
 }  // namespace chromeos