Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1095773003: Fix point count computation in tessellating path renderer. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix point count computation in tessellating path renderer. The conic, quadratic and cubic computations were using tolerance^2 instead of tolerance when computing maximum point count, causing paths to be undertessellated when magnifying and overtessellated when minifying. (Funny story: this bug went unnoticed back when we were tessellating paths in screen space, when tolerance and its square were both 1.) BUG=skia:3731 Committed: https://skia.googlesource.com/skia/+/6d88bdb6f1408ec9861ee1306a026e15c5bacc9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/gpu/GrTessellatingPathRenderer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Stephen White
Rob: PTAL. Thanks!
5 years, 8 months ago (2015-04-18 14:39:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095773003/1
5 years, 8 months ago (2015-04-20 12:20:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-20 12:34:59 UTC) #6
robertphillips
lgtm
5 years, 8 months ago (2015-04-20 12:41:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095773003/1
5 years, 8 months ago (2015-04-20 12:41:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6d88bdb6f1408ec9861ee1306a026e15c5bacc9c
5 years, 8 months ago (2015-04-20 12:41:51 UTC) #10
reed1
do we expect any layouttest failures/rebaselines?
5 years, 8 months ago (2015-04-20 13:30:44 UTC) #12
Stephen White
On 2015/04/20 13:30:44, reed1 wrote: > do we expect any layouttest failures/rebaselines? In Skia, yes. ...
5 years, 8 months ago (2015-04-20 14:07:34 UTC) #13
reed1
5 years, 8 months ago (2015-04-20 14:11:46 UTC) #14
Message was sent while issue was closed.
Ah, good (chrome)

No need for a list, as gold will take care of that :)

Powered by Google App Engine
This is Rietveld 408576698