Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1095763003: [chrome/browser/web_applications] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
jackhou1
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/web_applications BUG=466848 Committed: https://crrev.com/9fcea9a522715b35b643d93da38240f8da8c9208 Cr-Commit-Position: refs/heads/master@{#326238}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M chrome/browser/web_applications/web_app.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-22 05:39:16 UTC) #2
jackhou1
lgtm
5 years, 8 months ago (2015-04-22 05:48:56 UTC) #3
anujsharma
On 2015/04/22 05:48:56, jackhou1 wrote: > lgtm Thanks jackhou1 for lgtm.
5 years, 8 months ago (2015-04-22 05:49:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095763003/1
5 years, 8 months ago (2015-04-22 05:50:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 06:58:05 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 06:59:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fcea9a522715b35b643d93da38240f8da8c9208
Cr-Commit-Position: refs/heads/master@{#326238}

Powered by Google App Engine
This is Rietveld 408576698