Chromium Code Reviews| Index: build/android/pylib/run_java_tests.py |
| diff --git a/build/android/pylib/run_java_tests.py b/build/android/pylib/run_java_tests.py |
| index bf51bad943b928c03d309a37b975697f3285cddc..4a22d5531b23ba39bc74bfb9605dcc568170ecca 100644 |
| --- a/build/android/pylib/run_java_tests.py |
| +++ b/build/android/pylib/run_java_tests.py |
| @@ -130,8 +130,7 @@ class TestRunner(BaseTestRunner): |
| self.ports_to_forward = ports_to_forward |
| self.test_results = TestResults() |
| - # List of forwarders created by this instance of TestRunner. |
| - self.forwarders = [] |
| + self.forwarder = None |
| if self.coverage: |
| if os.path.exists(TestRunner._COVERAGE_MERGED_FILENAME): |
| @@ -277,19 +276,19 @@ class TestRunner(BaseTestRunner): |
| self.LaunchTestHttpServer(os.path.join(constants.CHROME_DIR), |
| (constants.LIGHTTPD_RANDOM_PORT_FIRST + |
| self.shard_index)) |
| - |
| + port_pairs = [] |
|
bulach
2012/09/26 15:13:11
nit: can move this to 281 directly and remove the
felipeg
2012/09/26 18:06:03
Done.
|
| if self.ports_to_forward: |
| for port in self.ports_to_forward: |
| - self.forwarders.append(Forwarder( |
| - self.adb, [(port, port)], self.tool, '127.0.0.1', self.build_type)) |
| + port_pairs.append([(port, port)]) |
| + self.forwarder = Forwarder( |
| + self.adb, port_pairs, self.tool, '127.0.0.1', self.build_type) |
| self.CopyTestFilesOnce() |
| self.flags.AddFlags(['--enable-test-intents']) |
| def TearDown(self): |
| """Cleans up the test harness and saves outstanding data from test run.""" |
| - if self.forwarders: |
| - for forwarder in self.forwarders: |
| - forwarder.Close() |
| + if self.forwarder: |
| + self.forwarder.Close() |
| self.GenerateCoverageReportIfNeeded() |
| super(TestRunner, self).TearDown() |