Adapt python scripts to use the new Forwarder2

tools/android/forwarder2/host_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/android/forwarder2/host_controller.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 50 matching lines @@
   forwarder->Start();
 }
 
 bool HostController::Connect() {
   if (!adb_control_socket_.ConnectTcp("", adb_port_)) {
     LOG(ERROR) << "Could not Connect HostController socket on port: "
                << adb_port_;
     return false;
   }
   // Send the command to the device start listening to the "device_forward_port"
-  SendCommand(command::LISTEN, device_port_, &adb_control_socket_);
+  CHECK(SendCommand(command::LISTEN, device_port_, &adb_control_socket_));

[bulach, 2012/09/26 15:13:11]

nit: it's fairly uncommon to call non-const methods inside CHECKs, i.e., to do
work there.. I think a more common idiom is:
bool ret = SendCommand(...);
CHECK(ret);

[felipeg, 2012/09/26 18:06:03]

Done.

   int device_port_allocated;
   command::Type command;
   if (!ReadCommand(&adb_control_socket_, &device_port_allocated, &command) ||
       command != command::BIND_SUCCESS) {
     LOG(ERROR) << "Device binding error using port " << device_port_;
     adb_control_socket_.Close();
     return false;
   }
   // When doing dynamically allocation of port, we get the port from the
   // BIND_SUCCESS command we received above.
@@ skipping 32 matching lines @@
     }
     SendCommand(command::HOST_SERVER_SUCCESS,
                 device_port_,
                 &adb_control_socket_);
     StartForwarder(host_server_data_socket.Pass());
   }
   adb_control_socket_.Close();
 }
 
 }  // namespace forwarder2