Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10957035: Adapted tests to API change. (Closed)

Created:
8 years, 3 months ago by phoglund_chromium
Modified:
8 years, 3 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Adapted tests to API change. BUG= NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=158031

Patch Set 1 #

Patch Set 2 : Updated tests after API change #

Patch Set 3 : Fixed bug in the tests that slipped through earlier. #

Patch Set 4 : Also fixed include in video quality test. #

Patch Set 5 : Fixed video quality test, which will be coming up soon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/test/data/webrtc/getusermedia.js View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/data/webrtc/jsep01_call.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webrtc/video_extraction.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/webrtc_video_quality_test.html View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/functional/media_stream_infobar.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/functional/webrtc_test_base.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Please commit this guy right away if you think it's good. Our tests are broken ...
8 years, 3 months ago (2012-09-21 09:47:01 UTC) #1
Nirnimesh
lgtm
8 years, 3 months ago (2012-09-21 18:29:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/10957035/9001
8 years, 3 months ago (2012-09-21 18:29:53 UTC) #3
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 18:30:37 UTC) #4
Change committed as 158031

Powered by Google App Engine
This is Rietveld 408576698