GrabWindowSnapshotTest.TestGrabWindowSnapshot fails in HighDPI

GrabWindowSnapshotTest.TestGrabWindowSnapshot fails in HighDPI

Fixes snapshot test to work on HighDPI Mac.

BUG=140924
TEST=GrabWindowSnapshotTest.TestGrabWindowSnapshot
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157993

[Nico, 2012-09-21 03:37:44]

lgtm

thanks!

https://codereview.chromium.org/10957031/diff/1/chrome/browser/ui/window_snap...
File chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm (right):

https://codereview.chromium.org/10957031/diff/1/chrome/browser/ui/window_snap...
chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:54:
EXPECT_EQ(400UL * scaleFactor, CGImageGetWidth([rep CGImage]));
Do you need the UL? It's multiplied by a float, the result's float too.

[dhollowa, 2012-09-21 04:06:51]

https://codereview.chromium.org/10957031/diff/1/chrome/browser/ui/window_snap...
File chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm (right):

https://codereview.chromium.org/10957031/diff/1/chrome/browser/ui/window_snap...
chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:54:
EXPECT_EQ(400UL * scaleFactor, CGImageGetWidth([rep CGImage]));
Ah yes, I'd converted to UL prior to adding the scale factor fix.  Done.

On 2012/09/21 03:37:44, Nico wrote:
> Do you need the UL? It's multiplied by a float, the result's float too.

[commit-bot: I haz the power, 2012-09-21 04:06:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10957031/7001

[commit-bot: I haz the power, 2012-09-21 04:13:55]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-09-21 04:16:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10957031/7001