Ensuring Google Update at user-level is installed alongside App Host, for the quick-enable App Host…

chrome/installer/util/google_update_util.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_UTIL_H_
+#define CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_UTIL_H_
+
+#include "base/command_line.h"

[erikwright (departed), 2012/09/20 18:00:01]

forward decl

[huangs, 2012/09/21 01:43:14]

Done (deleted since it's no longer needed).

+#include "base/file_path.h"

[erikwright (departed), 2012/09/20 18:00:01]

forward decl

[huangs, 2012/09/21 01:43:14]

Done (deleted since it's no longer needed).

+#include "base/string16.h"

[erikwright (departed), 2012/09/20 18:00:01]

not required.

[huangs, 2012/09/21 01:43:14]

Done.

+
+namespace google_update {

[grt (UTC plus 2), 2012/09/20 17:58:51]

google_update -> installer

[huangs, 2012/09/21 01:43:14]

No-op: I'm following google_update_constants.cc, which uses the "google_udpate"
namespace.  Will change if you insist.

+
+// Returns GoogleUpdateSetup.exe's executable path at |system_level|,
+// or an empty path if none is found.
+FilePath GetGoogleUpdateSetupExePathString(bool system_level);

[erikwright (departed), 2012/09/20 18:00:01]

PathString -> Path

[huangs, 2012/09/21 01:43:14]

Done.  Also making the routine local, until it is needed outside.

+
+// Appends "/install runtime=true&needsadmin=false /silent" to |cmd_line|

[grt (UTC plus 2), 2012/09/20 17:58:51]

why is this a public function?  who would call it?

[huangs, 2012/09/21 01:43:14]

I was considering writing a unit test, since I'm disturbed by the fact that "&"
does not quotation, and there is NO mechanism to quote it in CommandLine if I
want.  But I'll make it local.

+// for GoogleUpdateSetup.exe, to install Google Update at user-level.
+void AppendUserLevelGoogleUpdateInstallParam(CommandLine& cmd_line);
+
+// If user-level Google Update is not installed, calls the system-level
+// GoogleUpdateSetup.exe to install it.
+bool EnsureUserLevelGoogleUpdateInstalled();

[erikwright (departed), 2012/09/20 18:00:01]

"Returns true if already installed or installed successfully. False if the
installation fails or times-out."

Update the implementation accordingly. See code in setup_main.cc that waits for
a process to complete.

[huangs, 2012/09/21 01:43:14]

Done.

+
+}  // namespace google_update
+
+#endif  // CHROME_INSTALLER_UTIL_GOOGLE_UPDATE_UTIL_H_