Issue 10957006: Fix another stupid bug in Gmail Checker on Chrome 21

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10957006: Fix another stupid bug in Gmail Checker on Chrome 21 (Closed)

Created:
8 years, 3 months ago by Aaron Boodman

Modified:
8 years, 3 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix another stupid bug in Gmail Checker on Chrome 21 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157664

Patch Set 2 : hate #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/common/extensions/docs/examples/extensions/gmail/background.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

https://codereview.chromium.org/10957006/diff/1/chrome/common/extensions/docs/examples/extensions/gmail/background.js File chrome/common/extensions/docs/examples/extensions/gmail/background.js (right): https://codereview.chromium.org/10957006/diff/1/chrome/common/extensions/docs/examples/extensions/gmail/background.js#newcode292 chrome/common/extensions/docs/examples/extensions/gmail/background.js:292: if (alarm && alarm.name == 'watchdog') { alarm is ...

8 years, 3 months ago (2012-09-19 23:54:37 UTC) #1

Matt Perry

8 years, 3 months ago (2012-09-19 23:56:42 UTC) #3

https://codereview.chromium.org/10957006/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/examples/extensions/gmail/background.js
(right):

https://codereview.chromium.org/10957006/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/examples/extensions/gmail/background.js:292: if
(alarm && alarm.name == 'watchdog') {
On 2012/09/19 23:54:37, Aaron Boodman wrote:
> alarm is undefined in m21 because this is coming from window.setTimeout

add a comment so we can remove the null check when we remove the fallback
support

Expand Messages | Collapse Messages

Issue 10957006: Fix another stupid bug in Gmail Checker on Chrome 21 (Closed)

Description

Patch Set 1 #

Patch Set 2 : hate #

Messages