Issue 1095683005: fix super ctor logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1095683005: fix super ctor logic (Closed)

Created:
5 years, 8 months ago by Jennifer Messerly

Modified:
5 years, 8 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -26 lines)			Patch
M	lib/runtime/dart/_interceptors.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/runtime/dart/_internal.js	View	1	6 chunks	+0 lines, -6 lines	0 comments	Download
M	lib/runtime/dart/_js_helper.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/runtime/dart/async.js	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	lib/runtime/dart/collection.js	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download
M	lib/runtime/dart/convert.js	View	1	10 chunks	+0 lines, -10 lines	0 comments	Download
M	lib/src/codegen/js_codegen.dart	View	1	3 chunks	+19 lines, -2 lines	0 comments	Download
M	test/codegen/expect/fieldtest.js	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

we were generating calls to super ctors that didn't exist

5 years, 8 months ago (2015-04-17 19:44:25 UTC) #3

Jennifer Messerly

5 years, 8 months ago (2015-04-21 16:33:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
2ad787a1517a13b6e3e4865034eff3669874c167 (presubmit successful).