Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1095683002: [chromecast] Add CAST_PRODUCT_TYPE controlled at build time. (Closed)

Created:
5 years, 8 months ago by gfhuang
Modified:
5 years, 8 months ago
Reviewers:
gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Add CAST_PRODUCT_TYPE controlled at build time. Committed: https://crrev.com/5dd60a660436c3ec8fbb4b45faf2d26de803142f Cr-Commit-Position: refs/heads/master@{#325521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/chromecast.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M chromecast/common/version.h.in View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gfhuang
5 years, 8 months ago (2015-04-16 20:48:55 UTC) #2
gunsch
lgtm
5 years, 8 months ago (2015-04-16 20:50:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095683002/1
5 years, 8 months ago (2015-04-16 21:14:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 21:46:12 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 21:48:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dd60a660436c3ec8fbb4b45faf2d26de803142f
Cr-Commit-Position: refs/heads/master@{#325521}

Powered by Google App Engine
This is Rietveld 408576698