Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1095673002: GN: depend on data deps of source sets. (Closed)

Created:
5 years, 8 months ago by brettw
Modified:
5 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: depend on data deps of source sets. Previously if a target depended on a source set and that source set had data deps, building the target would not force the data dep target to be built. This patch hooks up the dependencies such that this happens as expected. BUG=477104 Committed: https://crrev.com/2e7da8f156fa15da6a33780c992ba265a024b312 Cr-Commit-Position: refs/heads/master@{#325544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -5 lines) Patch
M tools/gn/ninja_binary_target_writer.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/gn/ninja_binary_target_writer_unittest.cc View 4 chunks +93 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
brettw
5 years, 8 months ago (2015-04-16 20:41:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095673002/1
5 years, 8 months ago (2015-04-16 20:42:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-16 21:16:05 UTC) #6
jam
is there a better reviewer than me?
5 years, 8 months ago (2015-04-16 22:13:48 UTC) #7
jam
rubberstamp lgtm
5 years, 8 months ago (2015-04-16 23:19:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095673002/1
5 years, 8 months ago (2015-04-16 23:22:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 23:25:29 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 23:27:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e7da8f156fa15da6a33780c992ba265a024b312
Cr-Commit-Position: refs/heads/master@{#325544}

Powered by Google App Engine
This is Rietveld 408576698