win: Fix a few clang style plugin warnings.

win: Fix a few clang style plugin warnings.

BUG=467287
R=dcheng@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/69eba06cd07978b5f310f175989ced3b626a8932

[Nico, 2015-04-16 20:16:39]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2015-04-16 21:03:26]

lgtm

https://codereview.chromium.org/1095653002/diff/1/base/message_loop/message_p...
File base/message_loop/message_pump_win.h (left):

https://codereview.chromium.org/1095653002/diff/1/base/message_loop/message_p...
base/message_loop/message_pump_win.h:28: virtual ~MessagePumpWin() {}
How don't we don't need this? I guess the plugin only complains if we explicitly
have this line and doesn't actually care about the inline-ness?

[Nico, 2015-04-16 21:06:59]

thanks!

https://codereview.chromium.org/1095653002/diff/1/base/message_loop/message_p...
File base/message_loop/message_pump_win.h (left):

https://codereview.chromium.org/1095653002/diff/1/base/message_loop/message_p...
base/message_loop/message_pump_win.h:28: virtual ~MessagePumpWin() {}
On 2015/04/16 21:03:26, dcheng wrote:
> How don't we don't need this? I guess the plugin only complains if we
explicitly
> have this line and doesn't actually care about the inline-ness?

It complains "virtual methods shouldn't be inline", but it doesn't say "complex
class has inline dtor" for this class – i guess this class has mostly pod
members, so it's below the threshold and the inline dtor is deemed small enough?

(but i didn't try this on win – maybe i'll have to send a follow-up and put this
back :-P)

[commit-bot: I haz the power, 2015-04-16 21:11:17]

Patchset 1 (id:??) landed as
https://crrev.com/69eba06cd07978b5f310f175989ced3b626a8932
Cr-Commit-Position: refs/heads/master@{#325513}

[Nico, 2015-04-16 21:11:55]

Committed patchset #1 (id:1) manually as
69eba06cd07978b5f310f175989ced3b626a8932 (presubmit successful).