net: add test for TLS_FALLBACK_SCSV

net/test/spawned_test_server/base_test_server.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_
 #define NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 137 matching lines @@
     // negotiates an intolerant TLS version in order to test version fallback.
     TLSIntolerantLevel tls_intolerant;
 
     // (Fake) SignedCertificateTimestampList (as a raw binary string) to send in
     // a TLS extension.
     // Temporary glue for testing: validation of SCTs is application-controlled
     // and can be appropriately mocked out, so sending fake data here does not
     // affect handshaking behaviour.
     // TODO(ekasper): replace with valid SCT files for test certs.
     std::string signed_cert_timestamps;
+
+    // fallback_scsv_enabled, if true, causes the server to process
+    // TLS_FALLBACK_SCSV cipher suites. This cipher suite is sent by Chrome

[wtc, 2013/12/10 16:28:27]

Nit: "cipher suites" should be singular. There is only one fallback SCSV.

[agl, 2013/12/10 17:53:43]

Done.

+    // when performing TLS version fallback in response to an SSL handshake
+    // failure. If this option is enabled then the server will reject fallback
+    // connections.
+    bool fallback_scsv_enabled;

[wtc, 2013/12/10 16:28:27]

Emilia is adding a new option for OCSP stapling here. To avoid merge conflicts,
I suggest we list fallback_scsv_enabled after "TLSIntolerantLevel
tls_intolerant" (which happens to be related).

Emilia's CL: https://codereview.chromium.org/92443002/

[agl, 2013/12/10 17:53:43]

Done.

   };
 
   // Pass as the 'host' parameter during construction to server on 127.0.0.1
   static const char kLocalhost[];
 
   // Initialize a TestServer listening on a specific host (IP or hostname).
   BaseTestServer(Type type,  const std::string& host);
 
   // Initialize a TestServer with a specific set of SSLOptions for HTTPS or WSS.
   explicit BaseTestServer(Type type, const SSLOptions& ssl_options);
@@ skipping 93 matching lines @@
   bool log_to_console_;
 
   scoped_ptr<ScopedPortException> allowed_port_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseTestServer);
 };
 
 }  // namespace net
 
 #endif  // NET_TEST_SPAWNED_TEST_SERVER_BASE_TEST_SERVER_H_