tools/cr/cr/base/android.py - Issue 1095613002: cr: Add support for GN build file generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/base/android.py

Issue 1095613002: cr: Add support for GN build file generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits addressed. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr/base/android.py

diff --git a/tools/cr/cr/base/android.py b/tools/cr/cr/base/android.py

index 6b25f584b1c490f7b20d430beb676310d6196432..13e44312c403e434fc0999cc3e9c55319aae5abe 100644

--- a/tools/cr/cr/base/android.py

+++ b/tools/cr/cr/base/android.py

@@ -38,7 +38,8 @@ class AndroidPlatform(cr.Platform):

'{CR_SRC}', 'build', 'android', 'test_runner.py'),

CR_ADB_GDB=os.path.join('{CR_SRC}', 'build', 'android', 'adb_gdb'),

CR_DEFAULT_TARGET='chrome_shell',

- GYP_DEF_OS='android'

+ GYP_DEF_OS='android',

+ GN_ARG_os='"android"'

)

def __init__(self):

« no previous file with comments | « tools/cr/cr/actions/gyp.py ('k') | tools/cr/cr/commands/init.py » ('j') | no next file with comments »