Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/cr/cr/base/android.py

Issue 1095613002: cr: Add support for GN build file generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remember generator choice. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/cr/cr/actions/gn.py ('K') | « tools/cr/cr/actions/gyp.py ('k') | tools/cr/cr/commands/init.py » ('j') | tools/cr/cr/commands/prepare.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cr/cr/base/android.py
diff --git a/tools/cr/cr/base/android.py b/tools/cr/cr/base/android.py
index 6b25f584b1c490f7b20d430beb676310d6196432..13e44312c403e434fc0999cc3e9c55319aae5abe 100644
--- a/tools/cr/cr/base/android.py
+++ b/tools/cr/cr/base/android.py
@@ -38,7 +38,8 @@ class AndroidPlatform(cr.Platform):
'{CR_SRC}', 'build', 'android', 'test_runner.py'),
CR_ADB_GDB=os.path.join('{CR_SRC}', 'build', 'android', 'adb_gdb'),
CR_DEFAULT_TARGET='chrome_shell',
- GYP_DEF_OS='android'
+ GYP_DEF_OS='android',
+ GN_ARG_os='"android"'
petrcermak 2015/04/17 16:14:54 Shouldn't it be GN_ARG_OS (capital "OS")?
Sami 2015/04/17 16:20:34 Unlike in gyp, gn attributes are generally lower c
)
def __init__(self):
« tools/cr/cr/actions/gn.py ('K') | « tools/cr/cr/actions/gyp.py ('k') | tools/cr/cr/commands/init.py » ('j') | tools/cr/cr/commands/prepare.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698