Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 10956076: Merge 157900 - Create a new URLRequestJobFactory for isolated request contexts. (Closed)

Created:
8 years, 3 months ago by awong
Modified:
8 years, 3 months ago
Reviewers:
awong
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org
Visibility:
Public.

Description

Merge 157900 - Create a new URLRequestJobFactory for isolated request contexts. Also includes unittest from tzik@: http://codereview.chromium.org/10956009/ Originally the isolated URLRequestContexts used the same URLRequestJobFactory instance as the "default" request context. This breaks filesystem: because the isolated context would incorrectly dispatch to FileSystemContext of the default URLRequestContext. This CL makes it so the isolated contexts do not share the same URLRequestJobFactory. There is now one URLRequestJobFactory per StoragePartition (the code equiv of one isolated context). Note that each RequestContext and MediaRequestContext pair still share the same URLRequestJobFactory. This is safe because they are in the isolation domain. High level changes are: - Each URLRequestJobFactory needs its own protocol_handler_interceptor which requires threading the parameter through all the URLRequestContext factory mess because this particular object must be created on the UI thread. - GetIsolatedMediaRequestContext no longer looks up the app context out of the profile. Instead GetIsolatedMediaRequestContextGetter() does this. This makes it a little clearer that it is really a thin facade over the related isolated context. - The common code for URLJobFactory creation is pulled up into SetUpJobFactoryDefaults out of both off_the_record and the normal profile_impl. This will avoid future divergence of the setup. - FtpProtocolHandler also moved into SetUpJobFactoryDefaults. Again, this is just to avoid future divergence. - Lots of ownership passing moved to scoped_ptr<> to be more explicit. No functionality change here, but lots of text churn. TBR=finnur BUG=150861 Review URL: https://codereview.chromium.org/10969017 TBR=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -188 lines) Patch
M chrome/browser/extensions/extension_fileapi_apitest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 4 chunks +34 lines, -18 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 8 chunks +45 lines, -54 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 11 chunks +70 lines, -63 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 9 chunks +25 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 9 chunks +53 lines, -23 lines 0 comments Download
A chrome/test/data/extensions/api_test/xhr_persistent_fs/bg.js View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/xhr_persistent_fs/main.html View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/xhr_persistent_fs/main.js View 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/xhr_persistent_fs/manifest.json View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 2 chunks +20 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
awong
8 years, 3 months ago (2012-09-24 17:21:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698