Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 10956071: Merge 129094 - REGRESSION(r127727): Calendar picker focus ring should be hidden until key event (Closed)

Created:
8 years, 3 months ago by karen
Modified:
8 years, 3 months ago
Reviewers:
keishi
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 129094 - REGRESSION(r127727): Calendar picker focus ring should be hidden until key event https://bugs.webkit.org/show_bug.cgi?id=97165 Reviewed by Kent Tamura. The regression was caused because NoFocusRing class was being removed from then main element inside resetMain(). No new tests. Covered by calendar-picker-appearance.html. * Resources/pagepopups/calendarPicker.js: (initialize): (CalendarPicker): (CalendarPicker.prototype._layout): (DaysTable.prototype._handleKey): (CalendarPicker.prototype._handleBodyKeyDown): (CalendarPicker.prototype.maybeUpdateFocusStyle): Make this a method of CalendarPicker because we don't use it for other pickers. TBR=keishi@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/WebCore/Resources/pagepopups/calendarPicker.js View 7 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 3 months ago (2012-09-24 14:00:59 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698